| Submitter | shishir gowda |
|---|---|
| Date | 2011-03-22 11:14:21 |
| Message ID | <20110322111421.GA23777@dev.gluster.com> |
| Download | mbox | patch |
| Permalink | /patch/6556/ |
| State | Accepted |
| Delegated to: | Pavan C |
| Headers | show |
Comments
reviewed ok. ----- Original Message ----- > From: "shishir gowda" <shishirng@gluster.com> > To: glusterfs@dev.gluster.com > Sent: Tuesday, March 22, 2011 3:14:21 PM > Subject: [PATCH BRANCH:release-3.1 BUG:2566 2/2] Solaris: redefine O_DIRECTORY flag to the correct value > O_DIRECTORY is not supported on non-linux systems. By defining it > as 0, the check in qr_open always fails with error ENOTDIR. > > We need to document the limiation of not supporting O_DIRECTORY flag > when solaris is used as a backend. > > Signed-off-by: shishir gowda <shishirng@gluster.com> > --- > libglusterfs/src/glusterfs.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/libglusterfs/src/glusterfs.h > b/libglusterfs/src/glusterfs.h > index c911a88..ea0c6d5 100644 > --- a/libglusterfs/src/glusterfs.h > +++ b/libglusterfs/src/glusterfs.h > @@ -61,7 +61,7 @@ > > #ifndef O_DIRECTORY > /* FreeBSD does not need O_DIRECTORY */ > -#define O_DIRECTORY 0 > +#define O_DIRECTORY 0200000 > #endif > > #ifndef EBADFD > -- > 1.7.0.4 > > _______________________________________________ > glusterfs mailing list > glusterfs@dev.gluster.com > http://dev.gluster.com/cgi-bin/mailman/listinfo/glusterfs
Patch
diff --git a/libglusterfs/src/glusterfs.h b/libglusterfs/src/glusterfs.h index c911a88..ea0c6d5 100644 --- a/libglusterfs/src/glusterfs.h +++ b/libglusterfs/src/glusterfs.h @@ -61,7 +61,7 @@ #ifndef O_DIRECTORY /* FreeBSD does not need O_DIRECTORY */ -#define O_DIRECTORY 0 +#define O_DIRECTORY 0200000 #endif #ifndef EBADFD
O_DIRECTORY is not supported on non-linux systems. By defining it as 0, the check in qr_open always fails with error ENOTDIR. We need to document the limiation of not supporting O_DIRECTORY flag when solaris is used as a backend. Signed-off-by: shishir gowda <shishirng@gluster.com> --- libglusterfs/src/glusterfs.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)