Patchwork [BUG:2598] NFS : Volume access option accepts only valid values.

login
register
Submitter Gaurav
Date 2011-03-28 10:00:28
Message ID <1301306428-12845-1-git-send-email-gaurav@gluster.com>
Download mbox | patch
Permalink /patch/6613/
State Accepted
Delegated to: Anand Avati
Headers show

Comments

Gaurav - 2011-03-28 10:00:28
From: Gaurav <gaurav@gluster.com>


Signed-off-by: Gaurav <gaurav@gluster.com>
---
 xlators/nfs/server/src/nfs.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Shehjar Tikoo - 2011-03-28 10:50:46
Reviewed OK.


gaurav@gluster.com wrote:
> From: Gaurav <gaurav@gluster.com>
> 
> 
> Signed-off-by: Gaurav <gaurav@gluster.com>
> ---
>  xlators/nfs/server/src/nfs.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/xlators/nfs/server/src/nfs.c b/xlators/nfs/server/src/nfs.c
> index 150fa23..0814146 100644
> --- a/xlators/nfs/server/src/nfs.c
> +++ b/xlators/nfs/server/src/nfs.c
> @@ -749,6 +749,7 @@ struct volume_options options[] = {
>          },
>          { .key  = {"nfs3.*.volume-access"},
>            .type = GF_OPTION_TYPE_STR,
> +          .value = {"read-only", "read-write"},
>            .description = "Type of access desired for this subvolume: "
>                           " read-only, read-write(default)"
>          },
Shehjar Tikoo - 2011-03-28 10:51:23
please send the same patch for release 3.1 too. Thanks
gaurav@gluster.com wrote:
> From: Gaurav <gaurav@gluster.com>
> 
> 
> Signed-off-by: Gaurav <gaurav@gluster.com>
> ---
>  xlators/nfs/server/src/nfs.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/xlators/nfs/server/src/nfs.c b/xlators/nfs/server/src/nfs.c
> index 150fa23..0814146 100644
> --- a/xlators/nfs/server/src/nfs.c
> +++ b/xlators/nfs/server/src/nfs.c
> @@ -749,6 +749,7 @@ struct volume_options options[] = {
>          },
>          { .key  = {"nfs3.*.volume-access"},
>            .type = GF_OPTION_TYPE_STR,
> +          .value = {"read-only", "read-write"},
>            .description = "Type of access desired for this subvolume: "
>                           " read-only, read-write(default)"
>          },

Patch

diff --git a/xlators/nfs/server/src/nfs.c b/xlators/nfs/server/src/nfs.c
index 150fa23..0814146 100644
--- a/xlators/nfs/server/src/nfs.c
+++ b/xlators/nfs/server/src/nfs.c
@@ -749,6 +749,7 @@  struct volume_options options[] = {
         },
         { .key  = {"nfs3.*.volume-access"},
           .type = GF_OPTION_TYPE_STR,
+          .value = {"read-only", "read-write"},
           .description = "Type of access desired for this subvolume: "
                          " read-only, read-write(default)"
         },