Patchwork [BRANCH:master,BUG:140,TAKE-2] client-protocol: log messages at DEBUG loglevel when client_bind on privileged port fails.

---
 transport/ib-verbs/src/name.c |    2 +-
 transport/socket/src/name.c   |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

> diff --git a/transport/ib-verbs/src/name.c b/transport/ib-verbs/src/name.c
> index 31ce529..10af5fd 100644
> --- a/transport/ib-verbs/src/name.c
> +++ b/transport/ib-verbs/src/name.c
> @@ -418,7 +418,7 @@ client_bind (transport_t *this,
>                                                         *sockaddr_len, 
>                                                         CLIENT_PORT_CEILING);
>                  if (ret == -1) {
> -                        gf_log (this->xl->name, GF_LOG_ERROR,
> +                        gf_log (this->xl->name, GF_LOG_DEBUG,
>                                  "cannot bind inet socket (%d) to port "
>                                  "less than %d (%s)", 
>                                  sock, CLIENT_PORT_CEILING, strerror (errno));

This log should definitely be a warning, and we should provide an option for the user to specify a range
of source ports. This actually came up in a sales call where the admins want to bind the source port of
glusterfs to a specific range to permit filesystem traffic across their firewall. Assume that by default
the range is 0-1024, and the admin can override this range with 'option bind-port-range NUM1-NUM2'. When
binding fails in this range, it should definitely be a warning and fallback to a non bind()ed connect().

> >                                                         *sockaddr_len, 
> >                                                         CLIENT_PORT_CEILING);
> >                  if (ret == -1) {
> > -                        gf_log (this->xl->name, GF_LOG_ERROR,
> > +                        gf_log (this->xl->name, GF_LOG_DEBUG,
> >                                  "cannot bind inet socket (%d) to port "
> >                                  "less than %d (%s)", 
> >                                  sock, CLIENT_PORT_CEILING, strerror (errno));
> 
> This log should definitely be a warning, and we should provide an option for the user to specify a range
> of source ports. This actually came up in a sales call where the admins want to bind the source port of
> glusterfs to a specific range to permit filesystem traffic across their firewall. Assume that by default
> the range is 0-1024, and the admin can override this range with 'option bind-port-range NUM1-NUM2'. When
> binding fails in this range, it should definitely be a warning and fallback to a non bind()ed connect().

Also, when you submit another take for the same patch, please mark the previous submission as 'Superseded'

Avati